RR [XS] : 8230711: ConnectionGraph::unique_java_object(Node* N) return NULL if n is not in the CG

[Doerr, Martin]

Hi Matthias,

looks good to me. Thanks for updating the copyright year which was forgotten before.

Best regards,
Martin


> -----Original Message-----
> From: hotspot-compiler-dev <hotspot-compiler-dev-
> bounces at openjdk.java.net> On Behalf Of Baesken, Matthias
> Sent: Freitag, 6. September 2019 17:04
> To: 'hotspot-compiler-dev at openjdk.java.net' <hotspot-compiler-
> dev at openjdk.java.net>
> Subject: RR [XS] : 8230711:
> ConnectionGraph::unique_java_object(Node* N) return NULL if n is not in
> the CG
> 
> Hello, please review this small  change .
> 
> In  https://bugs.openjdk.java.net/browse/JDK-8230363
> a graceful return has been added to method
> ConnectionGraph::not_global_escape(Node* n) if n is not in the CG .
> However a similar case exists in ConnectionGraph::unique_java_object .
> 
> Not all ideal nodes are added to the connection graph, it will result in a crash,
> though, if a node n that was not added to the connection graph is passed to
> ConnectionGraph::unique_java_object(Node* n).
> This case should be handled more gracefully by returning NULL .
> 
> 
> Bug/webrev :
> 
> https://bugs.openjdk.java.net/browse/JDK-8230711
> 
> http://cr.openjdk.java.net/~mbaesken/webrevs/8230711.0/
> 
> 
> Thanks, Matthias