RFR (S): 8230395: Code checks for NULL value returned from NEW_C_HEAP_ARRAY which can not happen

[David Holmes]

Hi Tobias,

Thanks for taking a look at this!

On 23/09/2019 5:04 pm, Tobias Hartmann wrote:
> Hi David,
> 
> On 19.09.19 07:57, David Holmes wrote:
>> webrev: http://cr.openjdk.java.net/~dholmes/8230395/webrev/
> 
> I've noticed the following:
> - os_perf_windows.cpp:596 "char* const", shouldn't this be "const char*"?

I don't think so (not that I changed it). The returned pointer is to 
malloc'd space so not a pointer to a "const char". The local variable is 
itself a const pointer because we never change it - not that that is 
significant in any way in this code.

> - os.cpp:1354 Excess whitespace in "s  ="

Thanks will fix that.

> Otherwise looks good to me.

Thanks again!

David

> Best regards,
> Tobias
>