RFR/RFC 8231503: [TESTBUG] compiler/{jvmci, aot} tests should not run with GCs that do not support JVMCI/AOT
Aleksey Shipilev
shade at redhat.com
Mon Sep 30 19:22:10 UTC 2019
On 9/30/19 7:51 PM, Vladimir Kozlov wrote:
> -XX:-UseJVMCICompiler is used explicitly to run Graal's unit tests to compare results with C2.
> Without it Graal will be loaded and used instead of C2 by default if +UseJVMCI is specified. These
> unit tests should not run with not support GCs.
>
> I don't think we should modify check in JVMCIGlobals::check_jvmci_supported_gc().
>
> I am fine with proposed changes in VMProps.java and I agree that JVMCI and AOT may have different
> GCs support even so currently they match.
Thanks, that's what I wanted to know.
I used Stefan's idea to use GC.selected(), which obviates the need for GC loop, and it seems to work
well for all GCs I tried:
https://cr.openjdk.java.net/~shade/8231503/webrev.02/
Testing: compiler/{jvmci,aot} with {<none>, Serial, Parallel, CMS, G1, Epsilon, Shenandoah, ZGC},
jdk-submit (running)
--
-Aleksey
More information about the hotspot-compiler-dev
mailing list