RFR: 8241438: Move IntelJccErratum mitigation code to platform-specific code

[Erik Österlund]

Hi Vladimir,

Thanks for the review.

/Erik

On 2020-04-02 11:31, Vladimir Ivanov wrote:
>
>> http://cr.openjdk.java.net/~eosterlund/8241438/webrev.03/
>
> Looks good.
>
> Best regards,
> Vladimir Ivanov
>
>>>> Here is an updated webrev with your concerns and Vladimir Ivanov's 
>>>> concerns addressed:
>>>> http://cr.openjdk.java.net/~eosterlund/8241438/webrev.02/
>>>>
>>>> Incremental:
>>>> http://cr.openjdk.java.net/~eosterlund/8241438/webrev.01_02/
>>>>
>>>> Thanks,
>>>> /Erik
>>>>
>>>>> Thanks,
>>>>> Vladimir
>>>>>
>>>>>>
>>>>>>> In pd_alignment_required() you implicitly use knowledge that 
>>>>>>> relocInfo::addr_unit() on x86 is 1.
>>>>>>> At least add comment about that.
>>>>>>
>>>>>> I can add a comment about that.
>>>>>>
>>>>>> New webrev:
>>>>>> http://cr.openjdk.java.net/~eosterlund/8241438/webrev.01/
>>>>>>
>>>>>> Incremental:
>>>>>> http://cr.openjdk.java.net/~eosterlund/8241438/webrev.00_01/
>>>>>>
>>>>>> Thanks,
>>>>>> /Erik
>>>>>>
>>>>>>> Thanks,
>>>>>>> Vladimir
>>>>>>>
>>>>>>> On 3/23/20 6:09 AM, Erik Österlund wrote:
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> There is some platform-specific code in PhaseOutput that deals 
>>>>>>>> with the IntelJccErratum mitigation,
>>>>>>>> which is ifdef:ed in shared code. It should move to 
>>>>>>>> platform-specific code.
>>>>>>>>
>>>>>>>> This patch exposes the iteration state of PhaseOutput, which 
>>>>>>>> allows hiding the Intel-specific code
>>>>>>>> completely in x86-specific files.
>>>>>>>>
>>>>>>>> Webrev:
>>>>>>>> http://cr.openjdk.java.net/~eosterlund/8241438/webrev.00/
>>>>>>>>
>>>>>>>> Bug:
>>>>>>>> https://bugs.openjdk.java.net/browse/JDK-8241438
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> /Erik
>>>>>>
>>>>
>>