RFR(S/M) : 8242310 : use reproducible random in hotspot compiler tests
Tobias Hartmann
tobias.hartmann at oracle.com
Wed Apr 8 06:17:46 UTC 2020
Hi Igor,
On 08.04.20 03:04, Igor Ignatyev wrote:
> - replaces fixed seed w/ 42 (in the tests which don't really depend on a seed value) as it's most common fixed seed in hotspot test suite;
What's the reason to use a fixed seed in the first place? Seems to me that even if the test does not
directly use the random value, it doesn't hurt to use a non-fixed seed. In fact, wouldn't using a
non-fixed seed increase coverage? Even if the value is not checked, it's still propagated through
registers, stack and heap space and might therefore make a difference.
> http://cr.openjdk.java.net/~iignatyev//8242310/webrev.00
Looks good.
Best regards,
Tobias
More information about the hotspot-compiler-dev
mailing list