RFR(S/M) : 8242310 : use reproducible random in hotspot compiler tests

Tobias Hartmann tobias.hartmann at oracle.com
Wed Apr 8 14:56:23 UTC 2020


Hi Igor,

On 08.04.20 16:47, Igor Ignatyev wrote:
> the thing is randomness (even reproducible) in tests comes w/ a price -- you had to be more careful when use such tests to verify fixes, compare results across different runs, etc. so in some cases, the possible gain in code coverage doesn't justify the drawbacks, and frankly I'm not a big fun of using something just b/c it might increase coverage in areas unrelated to the original goals of a test. I had to admit thought that I had several internal discussions w/ myself, at first I removed almost all fixed seed values, then I was going back and forth weighing pros and cons; at the end I decided to leave it as-is for now and reevaluate later on a test-by-test basis. 

Okay, fair enough. I agree that this discussion is independent of your fix.

Best regards,
Tobias


More information about the hotspot-compiler-dev mailing list