RFR(XS): 8242796: Fix client build failure

[Vladimir Kozlov]

Looks good.

Thanks,
Vladimir

On 4/19/20 11:30 PM, Yang Zhang wrote:
> Hi Vladimir
> 
> Thanks for your comment. I update the patch.
> http://cr.openjdk.java.net/~yzhang/8242796/webrev.02/
> 
> Regards
> Yang
> 
> -----Original Message-----
> From: Vladimir Kozlov <vladimir.kozlov at oracle.com>
> Sent: Saturday, April 18, 2020 3:07 AM
> To: Yang Zhang <Yang.Zhang at arm.com>; hotspot-compiler-dev at openjdk.java.net
> Subject: Re: RFR(XS): 8242796: Fix client build failure
> 
> Hi Yang
> 
> On 4/17/20 1:37 AM, Yang Zhang wrote:
>> Hi Vladimir
>>
>> I update the patch according to your comment.
>> http://cr.openjdk.java.net/~yzhang/8242796/webrev.01/
>>
>> These checks are needed.
>> #if INCLUDE_JFR && COMPILER2_OR_JVMCI
>> #if COMPILER2 ----------- without it, configuring --with-jvm-features=-compiler2 fails to build. The error is the same as before.
> 
> Yes, I agree that additional #ifdef COMPILER2 is needed.
> The only comment I have is to may be include compiler_c2 check under that #ifdef and leaving #endif at the same place:
> 
> + #ifdef COMPILER2
>       } else if (compiler_type == compiler_c2) {
> 
>         first_registration = false;
> + #endif // COMPILER2
>       }
> 
> Thanks,
> Vladimir
> 
>>
>> Regards
>> Yang
>>
>> -----Original Message-----
>> From: hotspot-compiler-dev
>> <hotspot-compiler-dev-bounces at openjdk.java.net> On Behalf Of Vladimir
>> Kozlov
>> Sent: Friday, April 17, 2020 5:27 AM
>> To: hotspot-compiler-dev at openjdk.java.net
>> Subject: Re: RFR(XS): 8242796: Fix client build failure
>>
>> Method register_jfr_phasetype_serializer() is only called when C2 or JVMCI code is included in JVM build.
>> I think you need to put whole method under checks:
>>
>> #if INCLUDE_JFR && COMPILER2_OR_JVMCI
>> // It appends new compiler phase names to growable array phase_names(a new CompilerPhaseType mapping // in compiler/compilerEvent.cpp) and registers it with its serializer.
>>
>> Thanks,
>> Vladimir
>>
>> On 4/16/20 1:58 AM, Yang Zhang wrote:
>>> Hi,
>>>
>>> Could you please help to review this patch?
>>>
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8242796
>>> Webrev: http://cr.openjdk.java.net/~yzhang/8242796/webrev.00/
>>>
>>> This build failure is introduced by JDK-8193210 [JVMCI/Graal] add JFR
>>> compiler phase/inlining events.
>>> C2 only code is used for JFR. To fix this issue, I use COMPILER2 macro.
>>>
>>> With this patch, x86 client build succeeds. But AArch64 client build
>>> still fails, which is caused by [1]. I have filed [2] for AArch64
>>> client build failure and will summit another patch for that.
>>>
>>> [1] https://bugs.openjdk.java.net/browse/JDK-8241665
>>> [2] https://bugs.openjdk.java.net/browse/JDK-8242905
>>>
>>> Regards
>>> Yang
>>>