RFR(S):8242429:Better implementation for signed extract

[Eric Liu]

Hi Vladimir,

Today we retriggered the job and it's passed all test cases.

The detail as below:

 Job: mach5-one-njian-JDK-8242429-2-20200423-0236-10421472
 BuildId: 2020-04-23-0235070.ningsheng.jian.source
 No failed tests
 Tasks Summary
	NOTHING_TO_RUN: 0
	UNABLE_TO_RUN: 0
	KILLED: 0
	NA: 0
	HARNESS_ERROR: 0
	FAILED: 0
	EXECUTED_WITH_FAILURE: 0
	PASSED: 84

I'm wondering whether it's necessary to check it again by some another reviewer.

Thanks,
Eric

-----Original Message-----
From: Vladimir Ivanov <vladimir.x.ivanov at oracle.com> 
Sent: Thursday, April 16, 2020 8:29 PM
To: Eric Liu <eric.c.liu at arm.com>; hotspot-compiler-dev at openjdk.java.net
Cc: nd <nd at arm.com>
Subject: Re: RFR(S):8242429:Better implementation for signed extract


> Webrev: http://cr.openjdk.java.net/~yzhang/ericliu/8242429/webrev.01/

Looks good.

Have you tested it through submit repo?

Best regards,
Vladimir Ivanov

> [Tests]
> Jtreg hotspot::hotspot_all_no_apps, jdk::jdk_core and langtools::tier1.
> No new failure found.
> 
> JMH: A simple JMH case [1] on AArch64 and AMD64 machines.
> 
> For AArch64, one platform has no obvious improvement, but on others 
> the performance gain is 7.3%~32.7%.
> 
> For AMD64, one platform has no obvious improvement, but on others the 
> performance gain is 13.7%~32.4%.
> 
> A simple test case [2] has checked the correctness for some corner 
> cases.
> 
> [1] 
> https://bugs.openjdk.java.net/secure/attachment/87712/IdealNegate.java
> [2] 
> https://bugs.openjdk.java.net/secure/attachment/87713/SignExtractTest.
> java
> 
> 
> Thanks,
> Eric
>