RFR(S/T) : 8243618 : compiler/rtm/cli tests can be run w/o WhiteBox

Tobias Hartmann tobias.hartmann at oracle.com
Mon Apr 27 08:27:00 UTC 2020


Hi Igor,

looks good and trivial.

Best regards,
Tobias

On 26.04.20 19:30, Igor Ignatyev wrote:
> http://cr.openjdk.java.net/~iignatyev/8243618/webrev.00/
>> 73 lines changed: 0 ins; 56 del; 17 mod;
> 
> 
> Hi all,
> 
> could you please review this small (and hopefully trivial) clean up in compiler/rtm/cli tests?
> from JBS:
>> JDK-8181124 replaced usages of compiler.testlibrary.rtm.predicate (which depended on WhiteBox API) w/ @requires, so now compiler/rtm/cli don't use WhiteBox API and can be run w/o it and given the actual testing is done the spawned JVMs by tests, the test code can also be run in driver mode.
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8243618
> webrev:
> testing: the affected tests
> 
> Thanks,
> -- Igor
> 


More information about the hotspot-compiler-dev mailing list