RFR(T) : 8243622 : all actions in compiler/aot/fingerprint/SelfChangedCDS.java can be run in driver mode

Tobias Hartmann tobias.hartmann at oracle.com
Mon Apr 27 08:30:48 UTC 2020


Hi Igor,

looks good and trivial.

Best regards,
Tobias

On 26.04.20 20:41, Igor Ignatyev wrote:
> http://cr.openjdk.java.net/~iignatyev//8243622/webrev.00
>> 10 lines changed: 0 ins; 0 del; 10 mod;
> 
> Hi all,
> 
> could you please review this trivial patch which updates SelfChangedCDS.java test to use driver mode for all its actions?
> from JBS:
>> compiler.aot.fingerprint.CDSRunner and CDSDumper classes spawn other JVMs to perform required actions, and there is no need for them (CDSRunner and CDSDumper) to be run w/ external vm flags, hence they can be run in a driver mode.
> 
> webrev: http://cr.openjdk.java.net/~iignatyev//8243622/webrev.00
> JBS: https://bugs.openjdk.java.net/browse/JDK-8243622
> testing: the affected test
> 
> Thanks,
> -- Igor
> 


More information about the hotspot-compiler-dev mailing list