RFR(S/T) : 8243619 : compiler/codecache/CheckSegmentedCodeCache.java test misses -version

Tobias Hartmann tobias.hartmann at oracle.com
Mon Apr 27 08:28:04 UTC 2020


Hi Igor,

looks good and trivial.

Best regards,
Tobias

On 26.04.20 19:41, Igor Ignatyev wrote:
> http://cr.openjdk.java.net/~iignatyev//8243619/webrev.00
>> 22 lines changed: 11 ins; 0 del; 11 mod;
> 
> Hi all,
> 
> could you please review this small and trivial clean up of CheckSegmentedCodeCache.java test?
> from JBS:
>> in several cases, compiler/codecache/CheckSegmentedCodeCache.java test doesn't pass -version to a forked JVM, and although it's not a problem b/c these cases are expected to fail, it's better to have -version in order to minimize chances of false-positive (should the way JVM handles flags get changed).
> 
> webrev: http://cr.openjdk.java.net/~iignatyev//8243619/webrev.00
> testing: the affected test
> JBS: https://bugs.openjdk.java.net/browse/JDK-8243619
> 
> Thanks,
> -- Igor
> 


More information about the hotspot-compiler-dev mailing list