RFR(XS): Provide information when hitting a HaltNode for architectures other than x86

Liu, Xin xxinliu at amazon.com
Thu Apr 30 04:02:56 UTC 2020


Hi, 

Could you review this small patch?  It unifies codegen of HaltNode for other architectures. 
JBS: https://bugs.openjdk.java.net/browse/JDK-8230552
Webrev: https://cr.openjdk.java.net/~xliu/8230552/00/webrev/

I tested on aarch64.  It generates the same crash report as x86_64 when it does hit HaltNode.  Halt reason is displayed. I paste report on the JBS.
I ran hotspot:tier1 on aarch64 fastdebug build.  It passed except for 3 relevant failures[1].
  
I plan to do that on aarch64 only, but it’s trivial on other architectures, so I bravely modified them all.  May I invite s390, SPARC arm32 maintainers take a look at it?
If it goes through the review, I hope a sponsor can help me to push the submit repo and see if it works.  
 
[1] those 3 tests failed on aarch64 with/without my changes. 
gc/shenandoah/mxbeans/TestChurnNotifications.java#id2
gc/shenandoah/mxbeans/TestChurnNotifications.java#id1
gc/shenandoah/mxbeans/TestPauseNotifications.java#id1

thanks,
-lx




More information about the hotspot-compiler-dev mailing list