RFR[XS] : 8244186 : assertion failure test/jdk/javax/net/ssl/DTLS/RespondToRetransmit.java

Bhateja, Jatin jatin.bhateja at intel.com
Thu Apr 30 11:45:58 UTC 2020


Hi All,

Kindly review the patch which fixes assertion failures seen in some jtreg regression.

JBS: http://bugs.openjdk.java.net/browse/JDK-8244186
Webrev: http://cr.openjdk.java.net/~jbhateja/8244186/webrev.01/

Removing an assertion which prevents logic folding over cones already having a 
MacroLogic node as depicted by following graph[1].

Regards,
Jatin

[1] Original ideal Graph:
          |          | 
         [N1](XorV) [N2](XorV)
         / \        /  \
        /   \      /    \
       /     \    /      \
      /       \  /        \
     /         \/          \
    /         [N3](AndV)    \
   /         /   \           \
 [A]        /     \          [D]
           /       \
        [N4](AndV)  \
        /   \        \
      [B]   [C]     [N5](AndV)
                    /  \
                  [C]  [D]

Above DAG has two logic cone roots N1 & N2.

Folding logic on cone rooted at N1, MacroLogic node can have at most 3 distinct inputs:
          |          |
         [N1](XorV) [N2](XorV)
         / \        /  \
        /   \      /    \
       /     \    /      \
      /       \  /        \
     /         \/          \
    /         [N6](MacroL)  \
   /         / | \           \
  /         /  |  \           \
[A]       [B] [C] [D]        [D]
         

Folding logic on Cone rooted at N2:
          |               |
         [N1](XorV)     [N2](XorV)
         / \               \
        /   \               \
       /     \               \
      /       \              [N7] (MacroL)
     /         \            / | \
    /         [N6](MacroL) /  |  \
   /         / | \        [B][C] [D]
  /         /  |  \           
 A]        [B] [C] [D]       



       
     
                  

              




More information about the hotspot-compiler-dev mailing list