RFR(S) : 8251126 : nsk.share.GoldChecker should read golden file from ${test.src}

[David Holmes]

Hi Igor,

This seems fine. The code cleanup looks good too.

Thanks,
David

On 5/08/2020 9:58 am, Igor Ignatyev wrote:
> http://cr.openjdk.java.net/~iignatyev/8251126/webrev.00/
>> 37 lines changed: 7 ins; 20 del; 10 mod;
> 
> Hi all,
> 
> could you please review this patch?
> from JBS:
>> as of now, nsk.share.GoldChecker reads golden files from the current directory, which makes it necessary to copy golden files from ${test.src} before the execution of the tests which use GoldChecker.
> 
> after this patch, FileInstaller actions will become redundant in 103 of :vmTestbase_vm_compiler tests and will be removed by 8251127.
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8251126
> webrev: http://cr.openjdk.java.net/~iignatyev/8251126/webrev.00/
> testing: :vmTestbase_vm_compiler tests
> 
> 8251127: https://bugs.openjdk.java.net/browse/JDK-8251127
> 
> Thanks,
> -- Igor
> 
>