RFR 8249893: AARCH64: optimize the construction of the value from the bits of the other two

Andrew Haley aph at redhat.com
Wed Aug 5 09:08:39 UTC 2020


Hi,

On 8/4/20 5:56 PM, Boris Ulasevich wrote:

> gently reminding of this review request.

>> http://bugs.openjdk.java.net/browse/JDK-8249893
>> http://cr.openjdk.java.net/~bulasevich/8249893/webrev.00

I'm leaning towards no. The code is too complicated and difficult to
maintain for such a small gain. As I suggested to Eric Liu
<eric.c.liu at arm.com> when discussing 8248870, we should try
canonicalizing this stuff early in compilation then matching with
BFM rules.

-- 
Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671



More information about the hotspot-compiler-dev mailing list