RFR: 8161684: [testconf] Add VerifyOops' testing into compiler tiers
Leonid Mesnik
leonid.mesnik at oracle.com
Wed Aug 5 21:39:21 UTC 2020
Sure, will do.
Leonid
> On Aug 5, 2020, at 12:52 PM, igor.ignatyev at oracle.com wrote:
>
> Leonid,
>
> Could you please add a comment saying that this code should be reverted when 8209961 is fixed?
>
> — Igor
>
>> On Aug 5, 2020, at 11:54 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>>
>> Okay. Then you change is good.
>>
>> Thanks,
>> Vladimir K
>>
>>>> On 8/5/20 11:35 AM, Leonid Mesnik wrote:
>>> Hi
>>> I checked with Dean status of 8209961. He said that he run into some issue and it makes sense to disable VerifyOops for AOT now.
>>> Leonid
>>>>> On Aug 5, 2020, at 11:22 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>>>> Hi Leonid,
>>>> Dean is working on 8209961 fix and it can be done 'soon'.
>>>> How urgent your changes? Can you wait a little?
>>>> Thanks,
>>>> Vladimir K
>>>> On 8/5/20 10:54 AM, Leonid Mesnik wrote:
>>>>> Hi
>>>>> Could you please review following fix which disable testing of AOT when VerifyOops is enabled until https://bugs.openjdk.java.net/browse/JDK-8209961 <https://bugs.openjdk.java.net/browse/JDK-8209961> is fixed.
>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8161684 <https://bugs.openjdk.java.net/browse/JDK-8161684>
>>>>> diff:
>>>>> diff -r 0d5c9dffe1f6 test/jtreg-ext/requires/VMProps.java
>>>>> --- a/test/jtreg-ext/requires/VMProps.java Mon Jul 27 22:59:27 2020 +0200
>>>>> +++ b/test/jtreg-ext/requires/VMProps.java Wed Aug 05 10:50:20 2020 -0700
>>>>> @@ -380,6 +380,10 @@
>>>>> return "false";
>>>>> }
>>>>> + if (WB.getBooleanVMFlag("VerifyOops")) {
>>>>> + return "false";
>>>>> + }
>>>>> +
>>>>> switch (GC.selected()) {
>>>>> case Serial:
>>>>> case Parallel:
>>>>> Leonid
>
More information about the hotspot-compiler-dev
mailing list