RFR(XS): 8069411: Un-quarantine OverloadCompileQueueTest.java

Igor Ignatyev igor.ignatyev at oracle.com
Mon Aug 10 16:09:59 UTC 2020


Hi Evgeny,

I'm assuming that you haven't seen timeouts in your reproducing attempts either, correct?

the fix looks good (assuming to goes after 8251349)

-- Igor

> On Aug 10, 2020, at 7:22 AM, Evgeny Nikitin <evgeny.nikitin at oracle.com> wrote:
> 
> Hi,
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8069411
> Webrev: http://cr.openjdk.java.net/~enikitin//8069411/webrev.00/index.html
> 
> The test failed previously due to a specific Assert class design from 2015 [1]. Please note that getMessage gets called for every comparison, causing a string copy. So the OOME was not caused by a test design or failure, it was just a common OOME, and Assert class was stressing the VM by copying error messages.
> 
> These days Assert class has changed and I have run lengths attempting to reproduce OOME in that or any other place of the test. I suggest to enable the test in CI runs.
> 
> 
> Please review,
> //Evgeny Nikitin.
> 
> ========
> [1] http://cr.openjdk.java.net/~enikitin//8069411/webrev.00/index.html



More information about the hotspot-compiler-dev mailing list