RFR(XS): 8251349: Add TestCaseImpl to OverloadCompileQueueTest.java's build dependencies

Igor Ignatyev igor.ignatyev at oracle.com
Mon Aug 10 19:34:06 UTC 2020


LGTM
-- Igor

> On Aug 10, 2020, at 12:25 PM, Evgeny Nikitin <evgeny.nikitin at oracle.com> wrote:
> 
> Hi Igor,
> 
> I agree, using reflection would be better. For those using IDEs as well. Here's the new webrev:
> 
> http://cr.openjdk.java.net/~enikitin//8251349/webrev.01/index.html
> 
> Again, the same one-time test run in mach5 on 5 platforms.
> 
> Thanks in advance,
> //Evgeny
> 
> On 2020-08-10 18:04, Igor Ignatyev wrote:
>> Hi Evgeny,
>> the fix looks good. there is although another (arguable better) way to solve that: update test/hotspot/jtreg/compiler/codecache/stress/Helper.java to get TestCaseImpl classname from TestCaseImpl.class, so there will be statically detectable dependency b/w TestCaseImpl  and compiler/codecache/stress/Helper (and all test classes which use it, including OverloadCompileQueueTest), so the tests won't have to have explicit @build.
>> Thanks,
>> -- Igor
>>> On Aug 10, 2020, at 6:47 AM, Evgeny Nikitin <evgeny.nikitin at oracle.com> wrote:
>>> 
>>> Hi,
>>> 
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8251349
>>> Webrev: https://cr.openjdk.java.net/~enikitin/8251349/webrev.00/
>>> 
>>> The test loads said class (TestCaseImpl) as a resource from disk. The test obviously needs the class to get compiled in advance.
>>> 
>>> The change has been checked in mach5 for the 5 common platforms (passed).
>>> 
>>> Please review,
>>> /Evgeny Nikitin.



More information about the hotspot-compiler-dev mailing list