RFR(XS): 8251349: Add TestCaseImpl to OverloadCompileQueueTest.java's build dependencies

[Evgeny Nikitin]

Hi Igor,

Thank you. Please find the patch attached. I wonder how many such 
nano-fixes one needs to make to become a committer? :))

Thanks in advance,
// Evgeny.

On 2020-08-10 21:34, Igor Ignatyev wrote:
> LGTM
> -- Igor
> 
>> On Aug 10, 2020, at 12:25 PM, Evgeny Nikitin <evgeny.nikitin at oracle.com> wrote:
>>
>> Hi Igor,
>>
>> I agree, using reflection would be better. For those using IDEs as well. Here's the new webrev:
>>
>> http://cr.openjdk.java.net/~enikitin//8251349/webrev.01/index.html
>>
>> Again, the same one-time test run in mach5 on 5 platforms.
>>
>> Thanks in advance,
>> //Evgeny
>>
>> On 2020-08-10 18:04, Igor Ignatyev wrote:
>>> Hi Evgeny,
>>> the fix looks good. there is although another (arguable better) way to solve that: update test/hotspot/jtreg/compiler/codecache/stress/Helper.java to get TestCaseImpl classname from TestCaseImpl.class, so there will be statically detectable dependency b/w TestCaseImpl  and compiler/codecache/stress/Helper (and all test classes which use it, including OverloadCompileQueueTest), so the tests won't have to have explicit @build.
>>> Thanks,
>>> -- Igor
>>>> On Aug 10, 2020, at 6:47 AM, Evgeny Nikitin <evgeny.nikitin at oracle.com> wrote:
>>>>
>>>> Hi,
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8251349
>>>> Webrev: https://cr.openjdk.java.net/~enikitin/8251349/webrev.00/
>>>>
>>>> The test loads said class (TestCaseImpl) as a resource from disk. The test obviously needs the class to get compiled in advance.
>>>>
>>>> The change has been checked in mach5 for the 5 common platforms (passed).
>>>>
>>>> Please review,
>>>> /Evgeny Nikitin.
> 
-------------- next part --------------
# HG changeset patch
# User enikitin
# Date 1597084287 -7200
#      Mon Aug 10 20:31:27 2020 +0200
# Node ID 060dd595dda6a12a38ccd944a565b9bd23c1933e
# Parent  c379dc750a02918dda02809fbc9edb2711c4a6ee
8251349: Add TestCaseImpl to OverloadCompileQueueTest.java's build dependencies
Reviewed-by: iignatyev, kvn

diff -r c379dc750a02 -r 060dd595dda6 test/hotspot/jtreg/compiler/codecache/stress/Helper.java
--- a/test/hotspot/jtreg/compiler/codecache/stress/Helper.java	Mon Jul 27 11:34:19 2020 -0700
+++ b/test/hotspot/jtreg/compiler/codecache/stress/Helper.java	Mon Aug 10 20:31:27 2020 +0200
@@ -37,7 +37,7 @@
     public static final WhiteBox WHITE_BOX = WhiteBox.getWhiteBox();
 
     private static final long THRESHOLD = WHITE_BOX.getIntxVMFlag("CompileThreshold");
-    private static final String TEST_CASE_IMPL_CLASS_NAME = "compiler.codecache.stress.TestCaseImpl";
+    private static final String TEST_CASE_IMPL_CLASS_NAME = TestCaseImpl.class.getName();
     private static byte[] CLASS_DATA;
     static {
         try {