[aarch64-port-dev ] [16] RFR[S]: 8251216: Implement MD5 intrinsics on AArch64

[Andrew Haley]

On 12/08/2020 12:38, Stuart Monteith wrote:

 > The method "testDigest" generates an byte array of a given size,
 > with each element filled with it's own index & 0xff.
 >
 > The test is then run once, assumed uncompiled, it is then "warmed
 > up" and the first generated digest is compared against the digest
 > presumably generated by the intrinsic. This is the same test for all
 > of the message digest algorithms.
 >
 > I'd say the test is no worse than what has gone before. There are
 > additional tests under the jdk library tests, but nothing that
 > addresses the correctness of the MD5 algorithm implementation
 > itself.

Good grief. So there are no compliance tests in the test suite at all.

 > In terms of the status-quo, that patch looks ok to me. I think if
 > the testing is to be expanded, it should be expanded to all of the
 > message digest algorithms.

That's not much more that an excuse for doing nothing, IMO.

-- 
Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671