RFR(S): 8247732: validate user-input intrinsic_ids in ControlIntrinsic

[Liu, Xin]

hi, Nils, 

Thank you to elaborate the answer with a table. 

I don't know there are up to 4 approaches to affect compilation behaviors until this table!
I got it. I will work tests and make sure my next patch conform this spec. 

thanks, 
--lx

________________________________________
From: hotspot-compiler-dev <hotspot-compiler-dev-retn at openjdk.java.net> on behalf of Nils Eliasson <nils.eliasson at oracle.com>
Sent: Thursday, August 13, 2020 9:17 AM
To: hotspot-compiler-dev at openjdk.java.net
Subject: RE: [EXTERNAL] RFR(S): 8247732: validate user-input intrinsic_ids in ControlIntrinsic

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.



That table didn't come out right...

+-------------------------------------------------+-------+----------------------------------+
| ControlIntrinsics                               | valid |
invalid                          |
+-------------------------------------------------+-------+----------------------------------+
| vmflag                                          | ok    | print error
and don't start      |
+-------------------------------------------------+-------+----------------------------------+
| CompilerOracle: -XX:CompileCommand=             | ok    | print error
and continue         |
+-------------------------------------------------+-------+----------------------------------+
| CompilerDirectives: -XX:CompilerDirectivesFile= | ok    | print error
and don't start      |
+-------------------------------------------------+-------+----------------------------------+
| CompilerDirectives via jcmd                     | ok    | print error,
VM continues to run |
+-------------------------------------------------+-------+----------------------------------+

// Regards
Nils


On 2020-08-13 17:59, Nils Eliasson wrote:
>
> |+-------------------------------------------------+-------+----------------------------------+
> | ControlIntrinsics | valid | invalid |
> +-------------------------------------------------+-------+----------------------------------+
> | vmflag | ok | print error and don't start |
> +-------------------------------------------------+-------+----------------------------------+
> | CompilerOracle: -XX:CompileCommand= | ok | print error and continue
> |
> +-------------------------------------------------+-------+----------------------------------+
> | CompilerDirectives: -XX:CompilerDirectivesFile= | ok | print error
> and don't start |
> +-------------------------------------------------+-------+----------------------------------+
> | CompilerDirectives via jcmd | ok | print error, vm continues to run
> |
> +-------------------------------------------------+-------+----------------------------------+|