RFR: JDK-8251470: Add a development option equivalant to OptoNoExecute to C1 compiler

[Kazunori Ogata]

Hi Tobias,

Thank you for checking the webrev and pointing out InstallMethods option. 
I now realize that I failed to notice this option can be turned off.  I 
remember I checked its default value is true, but I wasn't aware that it's 
a command line option...

Regarding the change in javaCalls.cpp, I made this change when I was 
debugging my changes to support new instructions.  I also made another 
change to make my code work.  I guess I should have revisit the change in 
javaCalls.cpp when my code became workable.  This change must not be 
necessary because my version of JVM works fine by only disabling 
InstallMethods.

Anyway, I agree this RFR is unnecessary.  Sorry for bothering you.


Regards,
Ogata


Tobias Hartmann <tobias.hartmann at oracle.com> wrote on 2020/08/13 16:00:20:

> From: Tobias Hartmann <tobias.hartmann at oracle.com>
> To: Kazunori Ogata <OGATAK at jp.ibm.com>, 
hotspot-compiler-dev at openjdk.java.net
> Date: 2020/08/13 16:02
> Subject: [EXTERNAL] Re: RFR: JDK-8251470: Add a development option 
> equivalant to OptoNoExecute to C1 compiler
> 
> Hi Ogata,
> 
> isn't that what -XX:-InstallMethods [1] is supposed to accomplish? It 
> triggers a bailout right
> before Compilation::install_code, which is the same with your code.
> 
> Also, why do you need the change in javaCalls.cpp? That would also 
affect 
> C2 compiled code.
> 
> Best regards,
> Tobias
> 
> [1] INVALID URI REMOVED
> 
u=http-3A__hg.openjdk.java.net_jdk_jdk_file_a7c030723240_src_hotspot_share_c1_c1-5Fglobals.hpp-23l292&d=DwICaQ&c=jf_iaSHvJObTbx-
> siA1ZOg&r=p-
> 
FJcrbNvnCOLkbIdmQ2tigCrcpdU77tlI2EIdaEcJw&m=9MlMOi5vGmX_CxK_2Eh5nMKekBrYPPdxQkvLPDv-
> isw&s=TWFHKEFoj6wwSylXbeLhsD7-tv5nCR50A6-iptKDC00&e= 
> 
> 
> On 12.08.20 09:48, Kazunori Ogata wrote:
> > Hi,
> > 
> > May I get review for JDK-8251470: Add a development option equivalant 
to 
> > OptoNoExecute to C1 compiler?
> > 
> > This patch adds a development option to compile a method with C1 and 
print 
> > disassembly of the generated native code, but to skip execution of the 

> > generated code, in the same manner as OptoNoExecute option does in C2.
> > 
> > Log-based debugging is useful to support a new processor.  In C1, the 
> > existing options BailoutAfterHIR and BailoutAfterLIR can be used if 
> > printing HIR/LIR is sufficient.  However, there is no way to print 
> > disassembly of the generated code because these existing options quit 
> > compilation before generating native code.  So this issue proposes a 
new 
> > option for this purpose.
> > 
> > 
> > Bug: INVALID URI REMOVED
> 
u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8251470&d=DwICaQ&c=jf_iaSHvJObTbx-
> siA1ZOg&r=p-
> 
FJcrbNvnCOLkbIdmQ2tigCrcpdU77tlI2EIdaEcJw&m=9MlMOi5vGmX_CxK_2Eh5nMKekBrYPPdxQkvLPDv-
> isw&s=JN0Zd_7HcvX3tVM-KdN-Q4hpX7Um5_muAy0Ma5sFWAI&e= 
> > Webrev: INVALID URI REMOVED
> u=http-3A__cr.openjdk.java.net_-7Eogatak_8251470_webrev.
> 00_&d=DwICaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=p-
> 
FJcrbNvnCOLkbIdmQ2tigCrcpdU77tlI2EIdaEcJw&m=9MlMOi5vGmX_CxK_2Eh5nMKekBrYPPdxQkvLPDv-
> isw&s=7Z4peF7vXvN0QRxSZALXIU3C91WHZWhS5pWyvRA4XlA&e= 
> > 
> > 
> > Regards,
> > Ogata
> > 
>