RFR(M): 8248190: PPC: Enable Power10 system and use new byte-reverse instructions
Michihiro Horie
HORIE at jp.ibm.com
Tue Aug 18 07:28:12 UTC 2020
Jose,
Latest change looks good also to me.
Marin,
Do you think if I can push the change?
Best regards,
Michihiro
----- Original message -----
From: "Doerr, Martin" <martin.doerr at sap.com>
To: "joserz at linux.ibm.com" <joserz at linux.ibm.com>
Cc: hotspot compiler <hotspot-compiler-dev at openjdk.java.net>,
"horie at jp.ibm.com" <horie at jp.ibm.com>
Subject: [EXTERNAL] Re: RFR(M): 8248190: PPC: Enable Power10 system and
use new byte-reverse instructions
Date: Wed, Jul 1, 2020 4:01 AM
Thanks for the much better flag description.
Looks good.
Best regards,
Martin
> Am 30.06.2020 um 02:15 schrieb "joserz at linux.ibm.com"
<joserz at linux.ibm.com>:
>
> Hello team,
>
> Here's the 2nd version, implementing the suggestions asked by Martin.
>
> Webrev:
https://cr.openjdk.java.net/~mhorie/8248190/webrev.01/
> Bug:
https://bugs.openjdk.java.net/browse/JDK-8248190
>
> Thank you!!
>
> Jose
>
>> On Sat, Jun 27, 2020 at 09:29:32AM +0000, Doerr, Martin wrote:
>> Hi Jose,
>>
>> Can you replace the outdated description of PowerArchitecturePPC64 in
globals_poc.hpp by something generic, please?
>>
>> Please update the Copyright year in vm_version_poc.hpp.
>>
>> I can‘t test the change, but it looks good to me.
>>
>> Best regards,
>> Martin
>>
>>>> Am 26.06.2020 um 20:29 schrieb "joserz at linux.ibm.com"
<joserz at linux.ibm.com>:
>>>
>>> Hello team!
>>>
>>> This patch introduces Power10 to OpenJDK and implements three new
instructions:
>>> - brh - byte-reverse halfword
>>> - brw - byte-reverse word
>>> - brd - byte-reverse doubleword
>>>
>>> Webrev:
https://cr.openjdk.java.net/~mhorie/8248190/webrev.00/
>>> Bug:
https://bugs.openjdk.java.net/browse/JDK-8248190
>>>
>>> Thanks for your review!
>>>
>>> Jose R. Ziviani
More information about the hotspot-compiler-dev
mailing list