[aarch64-port-dev ] RFR(L): 8231441: AArch64: Initial SVE backend support

[Andrew Dinn]

Hi Ningsheng,

>> postaloc.cpp:312 & 322
>>
>> 311     if (lrgs(val_idx).is_scalable()) {
>> 312       assert(val->ideal_reg() == Op_VecA, "scalable vector
>> register");
>>
>>          . . .
>>
>> 321       if (lrgs(val_idx).is_scalable()) {
>> 322         assert(val->ideal_reg() == Op_VecA, "scalable vector
>> register");
>>
>> You don't strictly need the asserts here as this is already asserted in
>> the call to is_scalable().
> 
> The assertion in LRG::is_scalable() is different, while this is an
> assertion for ideal_reg of a given node.
Yes, my apologies for misreading that. These assertions should be retained.

regards,


Andrew Dinn
-----------
Red Hat Distinguished Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill