RFR(S) : 8251996 : remove usage of PropertyResolvingWrapper in vm/compiler/complog/uninit

Igor Ignatyev igor.ignatyev at oracle.com
Fri Aug 21 03:18:50 UTC 2020


Vladimir, Katya,

thank you for your reviews, pushed.

-- Igor

> On Aug 20, 2020, at 5:17 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> 
> +1
> 
> Vladimir K
> 
> On 8/20/20 3:03 PM, Ekaterina Pavlova wrote:
>> Looks good,
>> -katya
>> On 8/20/20 1:47 PM, Igor Ignatyev wrote:
>>> http://cr.openjdk.java.net/~iignatyev//8251996/webrev.00
>>>> 75 lines changed: 13 ins; 29 del; 33 mod;
>>> 
>>> Hi all,
>>> 
>>> could you please review this small patch which removes usage of PropertyResolvingWrapper class from vm/compiler/complog/uninit?
>>> 
>>> a bit of background (from 8219140):
>>>> CODETOOLS-7902352 added support of using ${property} in action directive, so PropertyResolvingWrapper isn't needed anymore and can be removed.
>>> 
>>> jtreg can't pass "${test.vm.opts} ${test.java.opts}" as one option, so v.c.c.share.LogCompilationTest (used by and only by 13 complog/uninit tests) was updated to use j.t.lib.Utils::getTestJavaOpts() to get vm flags, and '-options "${test.vm.opts} ${test.java.opts}"' was removed from all 13 tests. the patch also slightly reformats LogCompilationTest: whitespace, imports cleanup, etc.
>>> 
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8251996
>>> webrev: http://cr.openjdk.java.net/~iignatyev//8251996/webrev.00
>>> testing: :vmTestbase_vm_compiler
>>> 
>>> Thanks,
>>> -- Igor
>>> 



More information about the hotspot-compiler-dev mailing list