RFR: 8252058: [JVMCI] Rework setting is_method_handle_invoke flag in jvmciCodeInstaller

[Dean Long]

+1

dl

On 8/21/20 1:07 PM, Vladimir Kozlov wrote:
> Looks good. Thank you for testing it with changed version.
>
> Vladimir K
>
> On 8/20/20 5:37 AM, Yudi Zheng wrote:
>> Please review this rework of setting is_method_handle_invoke flag in 
>> jvmciCodeInstaller.
>>
>> http://cr.openjdk.java.net/~yzheng/8252058/webrev.00/
>> https://bugs.openjdk.java.net/browse/JDK-8252058
>>
>> Changes since last time are at 
>> http://cr.openjdk.java.net/~yzheng/8252058/webrev.00/src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/GraalHotSpotVMConfig.java.udiff.html
>>
>> -Yudi
>>
>>> On 7 Jun 2020, at 23:14, Dean Long <dean.long at oracle.com> wrote:
>>>
>>> Looks good!
>>>
>>> dl
>>>
>>> On 6/7/20 1:06 PM, Yudi Zheng wrote:
>>>> Thanks Dean!
>>>> Here is a revision including your suggestion: 
>>>> http://cr.openjdk.java.net/~yzheng/8246347/webrev.01/
>>>>
>>>> -Yudi
>>>>
>>>>> On 6 Jun 2020, at 11:33, Dean Long <dean.long at oracle.com> wrote:
>>>>>
>>>>> I found a problem.  You need to make 
>>>>> CompiledMethod::is_deopt_mh_entry() look like is_deopt_entry() by 
>>>>> adding the JVMCI logic that looks backwards by the size of the 
>>>>> call instruction.
>>>>>
>>>>> dl
>>>>>
>>>>> On 6/4/20 12:03 AM, Yudi Zheng wrote:
>>>>>> I did not push this yet. It might require changes on the Graal 
>>>>>> side. I am still thinking about how to merge.
>>>>>>
>>>>>> -Yudi
>>>>>>
>>>>>>> On 4 Jun 2020, at 01:22, Dean Long <dean.long at oracle.com> wrote:
>>>>>>>
>>>>>>> Does this require recent Graal change in order to work correctly?
>>>>>>>
>>>>>>> dl
>>>>>>>
>>>>>>> On 6/3/20 3:47 PM, Dean Long wrote:
>>>>>>>> Hi Yudi.  I'm seeing an assert in 
>>>>>>>> test/jdk/java/lang/invoke/CallSiteTest.java with a debug build. 
>>>>>>>> Let me remove my changes and see if it still fails.  What 
>>>>>>>> testing did you do?
>>>>>>>>
>>>>>>>> dl
>>>>>>>>
>>>>>>>> On 6/2/20 9:38 AM, Yudi Zheng wrote:
>>>>>>>>> Hello,
>>>>>>>>>
>>>>>>>>> Please review this patch that sets is_method_handle_invoke 
>>>>>>>>> flag accordingly when describing scope at call site in 
>>>>>>>>> jvmciCodeInstaller.
>>>>>>>>>
>>>>>>>>> http://cr.openjdk.java.net/~yzheng/8246347/webrev.00/
>>>>>>>>> https://bugs.openjdk.java.net/browse/JDK-8246347
>>>>>>>>>
>>>>>>>>> Many thanks,
>>>>>>>>> Yudi
>>>>>
>>>>
>>>
>>