RFR(S) : 8252186 : remove FileInstaller action from vmTestbase/jit/graph tests

Igor Ignatyev igor.ignatyev at oracle.com
Mon Aug 24 20:24:22 UTC 2020


thanks Vladimir, pushed.

-- Igor

> On Aug 22, 2020, at 10:55 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> 
> LGTM
> 
> Thanks,
> Vladimir K
> 
> On 8/21/20 10:23 PM, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev/8252186/webrev.00/
>>> 24 lines changed: 0 ins; 12 del; 12 mod;
>> Hi all,
>> could you please review this small cleanup of vmTestbase/jit/graph tests?
>> from JBS:
>>> vmTestbase/jit/graph tests use FileInstaller to copy ${test.src}/data/main.data to the current directory, and pass the path to it as '-path' option to jit.graph.CGT class. since JDK-8252005 enabled jtreg smart action args, we can use ${test.src} right in the argument and avoid copying.
>> testing:  :vmTestbase_vm_compiler
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8252186
>> webrev: http://cr.openjdk.java.net/~iignatyev/8252186/webrev.00/
>> Thanks,
>> -- Igor



More information about the hotspot-compiler-dev mailing list