RFR (XS) 8252290: C2: Remove unused enum in CallGenerator

Reingruber, Richard richard.reingruber at sap.com
Tue Aug 25 09:28:32 UTC 2020


Hi Aleksey,

the cleanup looks good to me.

That enum was already part of the initial load with xxxunusedxxx as the only element [1].
So there's no open version history.

I could not find any references either (rtags, grep). Probably the enum had more elements
originally which were removed.

Thanks, Richard.

[1] https://github.com/openjdk/jdk/blame/d4626d89cc778b8b7108036f389548c95d52e56a/src/hotspot/share/opto/callGenerator.hpp#L41

-----Original Message-----
From: hotspot-compiler-dev <hotspot-compiler-dev-retn at openjdk.java.net> On Behalf Of Aleksey Shipilev
Sent: Dienstag, 25. August 2020 09:29
To: hotspot compiler <hotspot-compiler-dev at openjdk.java.net>
Subject: RFR (XS) 8252290: C2: Remove unused enum in CallGenerator

Small cleanup:
   https://bugs.openjdk.java.net/browse/JDK-8252290

Static code inspection complains the enum below is unused.

diff -r 13fdf97f0a8f src/hotspot/share/opto/callGenerator.hpp
--- a/src/hotspot/share/opto/callGenerator.hpp  Mon Aug 24 09:35:23 2020 +0200
+++ b/src/hotspot/share/opto/callGenerator.hpp  Tue Aug 25 09:27:45 2020 +0200
@@ -37,9 +37,4 @@

  class CallGenerator : public ResourceObj {
- public:
-  enum {
-    xxxunusedxxx
-  };
-
   private:
    ciMethod*             _method;                // The method being called.

Testing: grepping for "xxxunusedxxx", local builds

-- 
Thanks,
-Aleksey



More information about the hotspot-compiler-dev mailing list