[16] RFR(S): 8251093: Improve C1 register allocator logging and debugging support
Christian Hagedorn
christian.hagedorn at oracle.com
Wed Aug 26 11:10:41 UTC 2020
Hi Tobias
Thank you for your review!
On 25.08.20 14:37, Tobias Hartmann wrote:
> Hi Christian,
>
> On 19.08.20 16:06, Christian Hagedorn wrote:
>> http://cr.openjdk.java.net/~chagedorn/8251093/webrev.02/
> Looks good to me, just noticed some style issues (no new webrev required):
>
> c1_LinearScan.cpp:
> - Wrong indentation in lines 5445, 5509, 5681
Thanks, fixed it inline.
> TestTraceLinearScanLevel.java:
> - "... in a HelloWorld program". It's not a HelloWorld program, right? ;)
Oh, you're right! Should have written "... in a *silent* HelloWorld
program" :-)
Best regards,
Christian
More information about the hotspot-compiler-dev
mailing list