RFR (S) 8252215: Remove VerifyOptoOopOffsets flag

[Vladimir Kozlov]

I agree.

It does not even check that the field in particular offset is oop. It just check that there is a field for which we have 
a ton of other checks.
Also in shenandoahBarrierSetC2.cpp it check tp == NULL in assert after code already referenced through it!

Thanks,
Vladimir

On 8/25/20 5:43 AM, Tobias Hartmann wrote:
> Hi Aleksey,
> 
> looks good to me.
> 
> Best regards,
> Tobias
> 
> On 25.08.20 09:08, Aleksey Shipilev wrote:
>> RFE:
>>    https://bugs.openjdk.java.net/browse/JDK-8252215
>>
>> VerifyOptoOopOffsets flag does not seem to be used (no tests in the current test base), and it does
>> not seem to work reliably (see JDK-4834891). It might be a good time to remove it. JDK-4834891
>> evaluation says: "The flag VerifyOptoOopOffsets has not been valid since the introduction of
>> sun/misc/Unsafe and the flag should not be used for general testing."
>>
>> How about we remove it?
>>    https://cr.openjdk.java.net/~shade/8252215/webrev.01/
>>
>> Testing: tier1 (locally); jdk-submit (still running?)
>>