RFR: 8252404: compiler/c1/TestTraceLinearScanLevel.java fails with release VMs(Internet mail)

[Vladimir Kozlov]

Good.

Vladimir K

On 8/26/20 7:38 PM, jiefu(傅杰) wrote:
> Hi Vladimir K,
> 
> Thanks for your review.
> 
> Updated: http://cr.openjdk.java.net/~jiefu/8252404/webrev.01/
> 
> Best regards,
> Jie
> 
> 
> 
> ------------------------------------------------------------------------------------------------------------------------
> *From:* Vladimir Kozlov <vladimir.kozlov at oracle.com>
> *Sent:* Thursday, August 27, 2020 10:20 AM
> *To:* jiefu(傅杰); hotspot compiler
> *Subject:* Re: RFR: 8252404: compiler/c1/TestTraceLinearScanLevel.java fails with release VMs(Internet mail)
> Since test's method is empty, it does not make sense to run it when C1's flag is not available.
> 
> I suggest to add @requires instead of IgnoreUnrecognizedVMOptions flag, as in an other test [1]:
> 
> * @requires vm.debug == true & vm.compiler1.enabled
> 
> Thanks,
> Vladimir K
> 
> [1] http://hg.openjdk.java.net/jdk/jdk/file/6abdfb11f342/test/hotspot/jtreg/compiler/c1/TestPrintIRDuringConstruction.java
> 
> On 8/26/20 4:37 PM, jiefu(傅杰) wrote:
>> Hi all,
>> 
>> May I get reviews for this fix?
>> 
>> JBS:    https://bugs.openjdk.java.net/browse/JDK-8252404
>> Webrev: http://cr.openjdk.java.net/~jiefu/8252404/webrev.00/
>> 
>> Thanks.
>> Best regards,
>> Jie
>> 
>