RFR: 8257143: Enable JVMCI code installation tests on AArch64

[Nick Gasson]

On Mon, 30 Nov 2020 19:45:10 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> This set of jtreg tests test JVMCI code installation independently of
>> Graal. Currently they only run on x86 as the minimal assembler required
>> is only implemented for that platform. This patch implements the
>> TestAssembler for AArch64 to ensure JVMCI test coverage even if the
>> Graal embedded in OpenJDK is disabled/removed.
>
> src/hotspot/cpu/aarch64/relocInfo_aarch64.hpp line 35:
> 
>> 33:     offset_unit        =  1,
>> 34:     // Must be at least 1 for RelocInfo::narrow_oop_in_const.
>> 35:     format_width       =  1
> 
> Did you hit an issue with  = 0? Yes, it should be 1 for 64-bit. But I surprise nobody noticed this until now. How we handled embedded narrow_oop_in_const before?

The assertion `assert((format & format_mask) == format, "wrong format");` fails in `relocInfo::check_format_and_offset()`. That comes from the call in `jvmciCodeInstaller.cpp` line 866. I don't know why we don't see this with regular Graal usage. Maybe it doesn't use that relocation type on AArch64?

-------------

PR: https://git.openjdk.java.net/jdk/pull/1475