RFR: 8257502: Builds fail with new warnings after JDK-8256254 [v2]

Thomas Stuefe stuefe at openjdk.java.net
Tue Dec 1 12:50:58 UTC 2020


On Tue, 1 Dec 2020 11:44:13 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Default `x86_32` and `s390x` builds fail after JDK-8256254, because of the new warning:
>> 
>> x86_32:
>> 
>> 
>> 
>>  1291 | fatal("unexpected intrinsic id %d", iid);
>>       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~
>>       | |
>>       | vmIntrinsics::ID {aka vmIntrinsicID}
>>    ... (rest of output omitted)
>> 
>> s390x:
>> 
>> 
>> 
>>   923 | "special_dispatch=%d", special_dispatch);
>>       | ^~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~
>>       | |
>>    ... (rest of output omitted)
>> The fix is pretty trivial: do the same as other arches. I think it would have been caught by GH actions in #1237, if they actually ran...
>> 
>> Testing:
>>  - [x] Linux x86_32 fastdebug build
>>  - [x] Linux s390x fastdebug build
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Also fix S390X

Thanks Aleksey. LGTM.

-------------

Marked as reviewed by stuefe (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1536


More information about the hotspot-compiler-dev mailing list