RFR: 8257460: Further CompilerOracle cleanup [v3]

Claes Redestad redestad at openjdk.java.net
Tue Dec 1 20:45:56 UTC 2020


On Tue, 1 Dec 2020 09:35:11 GMT, Nils Eliasson <neliasso at openjdk.org> wrote:

>> I got some additional feedback on 8256508: "Improve CompileCommand flag" from Claes.
>> 
>> 1. The _type field in TypedMethodMatcher is not used any more. It is derived from the option.
>> 
>> 2. The verify_type argument is only used from whitebox API and the check should be pushed out to that code. The check is needed because the option is passed from java as a String and we need to verify that the value type matches the option type.
>>  
>> 3. The type parameter to TypedMethodMatcher::match isn't used.
>>  
>> 4. Some code only used for asserts was moved into assert
>
> Nils Eliasson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Move check of unknown option to slowpaths

Marked as reviewed by redestad (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/1528


More information about the hotspot-compiler-dev mailing list