RFR: 8257143: Enable JVMCI code installation tests on AArch64

Vladimir Kozlov kvn at openjdk.java.net
Tue Dec 1 21:50:57 UTC 2020


On Tue, 1 Dec 2020 12:11:57 GMT, Nick Gasson <ngasson at openjdk.org> wrote:

>> src/hotspot/cpu/aarch64/relocInfo_aarch64.hpp line 35:
>> 
>>> 33:     offset_unit        =  1,
>>> 34:     // Must be at least 1 for RelocInfo::narrow_oop_in_const.
>>> 35:     format_width       =  1
>> 
>> Did you hit an issue with  = 0? Yes, it should be 1 for 64-bit. But I surprise nobody noticed this until now. How we handled embedded narrow_oop_in_const before?
>
> The assertion `assert((format & format_mask) == format, "wrong format");` fails in `relocInfo::check_format_and_offset()`. That comes from the call in `jvmciCodeInstaller.cpp` line 866. I don't know why we don't see this with regular Graal usage. Maybe it doesn't use that relocation type on AArch64?

@dougxc Can you check why we did not hit this assert before?

BTW, I am fine with these changes.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1475


More information about the hotspot-compiler-dev mailing list