RFR: 8257146: C2: extend the scope of StressGCM

Vladimir Kozlov kvn at openjdk.java.net
Tue Dec 1 21:55:55 UTC 2020


On Tue, 1 Dec 2020 11:57:47 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Looks good to me but the test failures that you've found when running lower tiers should be investigated and fixed before integrating this to avoid frequent failures in the CI runs. I would suggest to defer this to JDK 17.
>> 
>> Also, as Vladimir already said, more testing should be executed. Please run the higher tiers as well.
>
>> Looks good to me but the test failures that you've found when running lower tiers should be investigated and fixed before integrating this to avoid frequent failures in the CI runs. I would suggest to defer this to JDK 17.
> 
> Fair point. My only concern with postponing the integration is that it could reduce the incentive to investigate the failures, as these will not be as visible.
> 
>> Also, as Vladimir already said, more testing should be executed. Please run the higher tiers as well.
> 
> Will do!

I agree with deferring it to JDK 17.  Meanwhile I suggest to investigate failing cases and file separate bug for them (which can be fixed in JDK 16).

-------------

PR: https://git.openjdk.java.net/jdk/pull/1469


More information about the hotspot-compiler-dev mailing list