Integrated: 8257190: simplify PhaseIdealLoop constructors

Tue Dec 1 23:53:56 UTC 2020

On Fri, 27 Nov 2020 00:07:53 GMT, Xin Liu <xliu at openjdk.org> wrote:

> 8257190: simplify PhaseIdealLoop constructors

This pull request has now been integrated.

Changeset: ce496cbd
Author:    Xin Liu <xliu at openjdk.org>
Committer: Jie Fu <jiefu at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/ce496cbd
Stats:     20 lines in 1 file changed: 4 ins; 11 del; 5 mod

8257190: simplify PhaseIdealLoop constructors

Currently, C2 has 3 private constructors of PhaseIdealLoop as follows. a-b are for verification. only c is for real loop optimizations.
a. PhaseIdealLoop( PhaseIterGVN &igvn)
b. PhaseIdealLoop(PhaseIterGVN &igvn, const PhaseIdealLoop *verify_me)
c. PhaseIdealLoop(PhaseIterGVN &igvn, LoopOptsMode mode)

I propose 3 changes to simplify them.
1. add assertion in the constructor c. C2 shouldn't use mode = LoopOptsVerify for it.
2. merge a and b into one constructor.
3. make the merged verification ctor only for debug builds.

Reviewed-by: thartmann, kvn

-------------

PR: https://git.openjdk.java.net/jdk/pull/1473