RFR: 8257182: JCK test failures in integer / long rotation tests

Christian Hagedorn chagedorn at openjdk.java.net
Thu Dec 3 10:56:02 UTC 2020


On Wed, 2 Dec 2020 16:13:36 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> src/hotspot/share/opto/mulnode.cpp line 1510:
>> 
>>> 1508:     if (r1->is_con() && r2->is_con()) {
>>> 1509:       unsigned int r1_con = (unsigned int)r1->get_con();
>>> 1510:       unsigned int shift = (unsigned int)(r2->get_con()) & (unsigned int)(BitsPerJavaInteger - 1); // semantics of Java shifts
>> 
>> I'd prefer to use juint which actually is the same, but would be more consistent IMHO.
>
> +1

I agree, I'll change it to `juint`

-------------

PR: https://git.openjdk.java.net/jdk/pull/1562


More information about the hotspot-compiler-dev mailing list