RFR: 8257436: [aarch64] Regressions in ArrayCopyUnalignedDst.testByte/testChar for 65-78 bytes when UseSIMDForMemoryOps is on [v3]

Evgeny Astigeevich github.com+42899633+eastig at openjdk.java.net
Thu Dec 3 14:10:17 UTC 2020


On Thu, 3 Dec 2020 09:57:39 GMT, Volker Simonis <simonis at openjdk.org> wrote:

>> Evgeny Astigeevich has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR.
>
> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 1158:
> 
>> 1156:       __ ldpq(v2, v3, Address(s, 32));
>> 1157:       // Unaligned pointers can be an issue for copying.
>> 1158:       // This have more chances to happen when granularity of data is
> 
> I think this should read "These have more.." or "This has more.."

Done

> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 1100:
> 
>> 1098:     const Register t0 = r3, t1 = r4;
>> 1099: 
>> 1100:     // <= 96 bytes do inline. Direction doesn't matter because we always
> 
> Can you please add both cases into the comment. Something like:
> 
> // <= 80 (or 96 for SIMD) do inline...

Done.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1558


More information about the hotspot-compiler-dev mailing list