RFR: 8257630: C2: ReplacedNodes doesn't handle non-CFG multi nodes

[Tobias Hartmann]

On Fri, 4 Dec 2020 07:36:16 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> src/hotspot/share/opto/replacednodes.cpp line 157:
>> 
>>> 155:           if (n->is_Proj()) {
>>> 156:             n = n->in(0);
>>> 157:           }
>> 
>> I would suggest to merge this with the if below and adjust the comment to something like:
>> `// Skip non-CFG nodes. Also skip projections, since some of the multi nodes aren't CFG (e.g., LoadStore and SCMemProj).`
>
> I considered that, but it would turn it into a while loop. Do you think it is worth it?

Ah right. No, that's probably not worth it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1580