RFR: 8247732: validate user-input intrinsic_ids in ControlIntrinsic [v9]

Tobias Hartmann thartmann at openjdk.java.net
Fri Dec 4 08:33:58 UTC 2020


On Fri, 4 Dec 2020 08:28:28 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8247732: validate user-input intrinsic_ids in ControlIntrinsic
>>   
>>   fix build failures on windows platform by using platform-natural MIN2.
>
> This patch causes failures with `compiler/compilercontrol/commands/ControlIntrinsicTest.java`:
>  
> java.lang.RuntimeException: CompileCommand: option *Internal*.* missing in output: expected true, was false
> 	at jdk.test.lib.Asserts.fail(Asserts.java:594)
> 	at jdk.test.lib.Asserts.assertTrue(Asserts.java:486)
> 	at compiler.compilercontrol.share.processors.CommandProcessor.check(CommandProcessor.java:73)

`compiler/compilercontrol/mixed/RandomValidCommandsTest.java` fails as well:
java.lang.RuntimeException: CompileCommand: option *.*$method missing in output: expected true, was false
	at jdk.test.lib.Asserts.fail(Asserts.java:594)
	at jdk.test.lib.Asserts.assertTrue(Asserts.java:486)
	at compiler.compilercontrol.share.processors.CommandProcessor.check(CommandProcessor.java:73)

-------------

PR: https://git.openjdk.java.net/jdk/pull/1179


More information about the hotspot-compiler-dev mailing list