RFR: 8257679: Improved unix compatibility layer in Windows build (winenv) [v3]

[Magnus Ihse Bursie]

On Thu, 3 Dec 2020 22:36:33 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> make/CreateJmods.gmk line 172:
>> 
>>> 170:   endif
>>> 171: else # not java.base
>>> 172:   ifeq ($(call isTargetOs, windows)+$(CREATING_BUILDJDK), true+false)
>> 
>> This looks strange. Why would CREATING_BUILDJDK be relevant here?
>
> If we are creating a buildjdk (which really means we are cross-compiling), we must not meddle with the Windows runtime dll:s, since they are for the target CPU architecture. To be *fully* correct, we should really turn the Windows runtime dll:s into a "normal"/BUILD_ split version, like with SYSROOT etc. 
> 
> But since this is just used locally for building, I'm assuming the build system has these runtime DLLs installed already. There seems to be no point in wasting time preparing a buildjdk with files that are just bundled for installation.
> 
> Maybe there's a better way to express this, but the only thing I could get a hold of for the fact that we are creating a build-JDK (that is, not targeting the normal OPENJDK_TARGET_CPU) was the CREATING_BUILDJDK variable.

I reverted this change, and added a comment when we copy the libs.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1597