RFR: 8257679: Improved unix compatibility layer in Windows build (winenv) [v4]

Erik Joelsson erikj at openjdk.java.net
Fri Dec 4 14:20:12 UTC 2020


On Fri, 4 Dec 2020 12:45:57 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Ok, it seems to have been caused by `usr/local/bin` being added to my Cygwin PATH in .bash_profile. If I remove that I get a little further.
>> 
>> But the same command fails later on a path with a space in it:
>> 
>> fixpath: failure: Path '/cygdrive/c/progra~2/ati technologies/ati.ace/core-static' contains space
>> 
>> Looks like a missing short/8dot3 path for one directory. I'll try to get it working on my end. I'll take further questions offline to keep this thread focused on the review.
>
> @JornVernee I have now pushed a fix that will make `fixpath import` ignore invalid or unknown paths be ignored. Please try again with it.

This looks good to me now, but seems GHA aren't completely ok with it yet.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1597


More information about the hotspot-compiler-dev mailing list