RFR: 8257679: Improved unix compatibility layer in Windows build (winenv) [v5]

[Magnus Ihse Bursie]

On Fri, 4 Dec 2020 17:34:33 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Ok, after looking at `set -x` output WSL seems to have a problem with the space in the path `/mnt/c/Program Files/Java/jdk-15` e.g. if I move the jdk to `/mnt/h/jdk-15` it works. Might be a missing fixup somewhere? (FWIW, that Program Files dir does have an 8dot3 name).
>> 
>> With that I can build `images` on both Cygwin and WSL. Build times are about 29 mins and 18 mins respectively.
>
> Do you see any significant difference in build times compared to before the patch?

The line numbers in the generated configure script seems to be mismatched; that can't have been the actual failing line.

This actual failing line is line 79 in boot-jdk.m4:

  BOOT_JDK_VERSION_OUTPUT=`$java_to_test $USER_BOOT_JDK_OPTIONS -version 2>&1`

If $java_to_test (and $USER_BOOT_JDK_OPTIONS) is empty,  then we try to execute `-version` and get this output. So the question is, why is java_to_test empty? The two preceding lines are:


          java_to_test="$BOOT_JDK/bin/java"
          UTIL_FIXUP_EXECUTABLE(java_to_test)

Sp java_to_test should be `/mnt/c/Program Files/Java/jdk-15/bin/java`. And obviously UTIL_FIXUP_EXECUTABLE rewrites this to the empty string. Why that is so, I don't know. Perhaps an issue with the space in the path.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1597