RFR: 8257679: Improved unix compatibility layer in Windows build (winenv) [v5]

[Magnus Ihse Bursie]

On Fri, 4 Dec 2020 15:57:44 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> @magicus Thanks! But, now I get the same error as the GH action: https://github.com/magicus/openjdk-sandbox/runs/1498822974#step:11:80
>> 
>> Looks like `-a` is not supported in my shell. I can make the error go away locally with:
>> 
>> diff --git a/make/scripts/fixpath.sh b/make/scripts/fixpath.sh
>> index ae5ca1f8a28..c7737a23eb8 100644
>> --- a/make/scripts/fixpath.sh
>> +++ b/make/scripts/fixpath.sh
>> @@ -207,7 +207,7 @@ function import_command_line() {
>>      if ! [[ $arg =~ ^" "+$ ]]; then
>>        import_path "$arg"
>> 
>> -      if [[ "$result" != "" -a "$imported" = "" ]]; then
>> +      if [[ "$result" != "" ]] && [[ "$imported" = "" ]]; then
>>          imported="$result"
>>        else
>>          imported="$imported:$result"
>> But I'm not sure that does the same thing.
>> 
>> After that, I can confirm that both path issues with Cygwin are resolved (`usr\local\bin` and paths with spaces don't cause a hard failure anymore).
>> 
>> ---
>> 
>> The issue with WSL still remains though:
>> 
>> configure: Found potential Boot JDK using configure arguments
>> configure: Potential Boot JDK found at /mnt/c/Program Files/Java/jdk-15 is not a working JDK; ignoring
>> configure: Output from java -version was: /mnt/h/cygwin64/home/Jorn/cygwin-projects-new/git-jdk2/build/.configure-support/generated-configure.sh: line 57167: -version: command not found
>> configure: error: The path given by --with-boot-jdk does not contain a valid Boot JDK
>> configure exiting with result code 1
>> 
>> Line 57167 in generated-configure.sh is this:
>> 
>>     # Now join together the path and the arguments once again
>>     new_complete="$prefix$new_path$arguments"
>
> Ok, after looking at `set -x` output WSL seems to have a problem with the space in the path `/mnt/c/Program Files/Java/jdk-15` e.g. if I move the jdk to `/mnt/h/jdk-15` it works. Might be a missing fixup somewhere? (FWIW, that Program Files dir does have an 8dot3 name).
> 
> With that I can build `images` on both Cygwin and WSL. Build times are about 29 mins and 18 mins respectively.

@JornVernee Ah, sorry, I missed that you had added yet another comment, with the solution! :-) I'll have a look at why the space is problematic. 

Do I understand you correctly that the same path to Java worked on Cygwin but failed on WSL?

-------------

PR: https://git.openjdk.java.net/jdk/pull/1597