RFR: 8252049: Native memory leak in ciMethodData ctor [v2]

[Vladimir Ivanov]

On Fri, 4 Dec 2020 21:58:38 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Vladimir Ivanov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>> 
>>  - Introduce MethodData::MDHeader class
>>  - Merge branch 'master' into 8252049.md.leak
>>  - Cleanup
>>  - Merge branch 'master' into 8252049.md.leak
>>  - Minor refactoring
>>  - Fix native memory leak in ciMethodData ctor
>
> src/hotspot/share/oops/methodData.hpp line 1972:
> 
>> 1970:   }; // Public flag values
>> 1971: 
>> 1972:   class MDHeader : public StackObj {
> 
> MDHeader appears to be a Value Obj and not a StackObj, so it shouldn't inherit from StackObj.

Fixed. 

And I was curious where `ValueObj`/`VALUE_OBJ_CLASS_SPEC` hide...  :-) Until I learned from JDK-8173070 and JDK-8198243 that it was retired for good.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1478