RFR: 8247732: validate user-input intrinsic_ids in ControlIntrinsic [v9]

Xin Liu xliu at openjdk.java.net
Sun Dec 6 11:42:12 UTC 2020


On Sun, 6 Dec 2020 10:17:32 GMT, Xin Liu <xliu at openjdk.org> wrote:

>> take a look the failure.
>
> **Analysis**
> 
> The failure of compiler/compilercontrol/commands/ControlIntrinsicTest.java is reproducible with `-XX:CompileThreshold=100`. RandomValidCommandsTest.java is a flaky test. Once it generates INTRINSIC commands in random test, it fails due to the same reason as  the first case. 
> 
> After JDK-8256508, the output message of option has changed. 
> now it outputs  message such as `CompileCommand: ControlIntrinsic *Klass.-()V const char* ControlIntrinsic = '+_newArray -_minF +_copyOf'` even thought the input  is `-XX:Compilecommand=option,*Klass.-()V,ControlIntrinsic,ccstr,+_newArray,-_minF,+_copyOf`. 
> 
> **Solution**
> I need to reformat CommandProcessor.getOutputString in test/hotspot/jtreg/compiler/compilercontrol/share/processors/CommandProcessor.java

Random  test `compiler/compilercontrol/mixed/RandomCommandsTest.java` may generate invalid method patterns and then run into [JDK-8257800](https://bugs.openjdk.java.net/browse/JDK-8257800). I need to solve that bug first.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1179


More information about the hotspot-compiler-dev mailing list