RFR: 8257800: CompileCommand TypedMethodOptionMatcher::parse_method_pattern() may over consume

[Nils Eliasson]

Hi,

Good that you fix this - but remember to stop using 'option' and start 
using the typed commands. I hope we can remove 'option' in JDK 17.

-XX:CompileCommand=option,*.*,uintx,MaxNodeLimit,10

   =>

-XX:CompileCommand=MaxNodeLimit,*.*,10

Regards,
Nils Eliasson


On 2020-12-06 23:57, Xin Liu wrote:
> if users don't specify method_name in CompileCommand, hotspot will over consume a token.
> in debug build, it may hit the assertion of type mismatch.
>
> -------------
>
> Commit messages:
>   - 8257800: CompileCommand TypedMethodOptionMatcher::parse_method_pattern() may over consume
>
> Changes: https://git.openjdk.java.net/jdk/pull/1652/files
>   Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1652&range=00
>    Issue: https://bugs.openjdk.java.net/browse/JDK-8257800
>    Stats: 16 lines in 1 file changed: 15 ins; 1 del; 0 mod
>    Patch: https://git.openjdk.java.net/jdk/pull/1652.diff
>    Fetch: git fetch https://git.openjdk.java.net/jdk pull/1652/head:pull/1652
>
> PR: https://git.openjdk.java.net/jdk/pull/1652