RFR: 8257848: -XX:CompileCommand=blackhole, * should be diagnostic [v2]

[Vladimir Kozlov]

On Mon, 7 Dec 2020 19:21:38 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert to check_predicate to match other should_* methods
>
> src/hotspot/share/compiler/compilerOracle.cpp line 414:
> 
>> 412: bool CompilerOracle::should_blackhole(const methodHandle& method) {
>> 413:   if (!check_predicate(CompileCommand::Blackhole, method)) {
>> 414:     return false;
> 
> Review self-comment. In fact, I am not sure if this should be `check_predicate` (like other commands), or `has_option` (like other options). CompilerOracle refactoring in JDK-8256508 seem to have converged both to mean the same. I left `check_predicate` as in original, and it also matches other `should_*`, see the definitions just above.

I think using `check_predicate` is perfectly fine in this case.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1674