RFR: 8257848: -XX:CompileCommand=blackhole, * should be diagnostic [v5]

[Aleksey Shipilev]

> This follows up on retroactive CSR review comments (JDK-8257827). As the result of discussion, it is decided to demote the "blackhole" compile command to diagnostic. Examples:
> 
> $ build/linux-x86_64-server-release/images/jdk/bin/java -Xcomp -XX:CompileCommand=quiet -XX:CompileCommand=blackhole,java/lang/Object.toString
> OpenJDK 64-Bit Server VM warning: Blackhole compile option is diagnostic and must be enabled via -XX:+UnlockDiagnosticVMOptions
> 
> $ build/linux-x86_64-server-release/images/jdk/bin/java -Xcomp -XX:+UnlockDiagnosticVMOptions -XX:CompileCommand=quiet -XX:CompileCommand=blackhole,java/lang/Object.toString
> OpenJDK 64-Bit Server VM warning: Blackhole compile option only works for methods with void type: java.lang.Object.toString()Ljava/lang/String;
> 
> New test verifies the locking/unlocking of the command.
> 
> Testing:
>  - [x] ad-hoc `compiler/blackhole` test
>  - [x] validation runs with JMH
>  - [ ] runs in `tier1` (needs #1654 to be merged)

Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:

 - Move guarantee closer to check_predicate
 - Merge branch 'master' into JDK-8257848-bh-diagnostic
 - Check blackhole unlocking at startup
 - Merge branch 'master' into JDK-8257848-bh-diagnostic
 - Revert to check_predicate to match other should_* methods
 - 8257848: -XX:+CompilerCommand=blackhole,* should be diagnostic

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/1674/files
  - new: https://git.openjdk.java.net/jdk/pull/1674/files/cbc07869..71c69c37

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1674&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1674&range=03-04

  Stats: 973 lines in 31 files changed: 675 ins; 164 del; 134 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1674.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1674/head:pull/1674

PR: https://git.openjdk.java.net/jdk/pull/1674